Ignore existing release null body #104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the SOLIDSoftworks/semver-tags action will result in a release created that doesn't contain anything for the release body. The consequences is that the updated release body will appear to contain the string `null` followed by a newline and then the release body as specified for this action. In such a case it appears to make more sense to ignore the existing release body should it be currently `null` instead of implicitly converting it to a string for the updated release body.
electrofelix
changed the title
|
thanks @filips123 but I already merged in #109 which mentioned it might have solved this. Im going to working on cutting a release and will then follow up if it doesn't I'll follow up on this pr |
|
@softprops think you tagged the wrong person, but either way happy to see if fixed. Looks to me like the other PR covers this case, so closing and deleting the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the SOLIDSoftworks/semver-tags action will result in a release
created that doesn't contain anything for the release body. The
consequences is that the updated release body will appear to contain the
string
nullfollowed by a newline and then the release body asspecified for this action.
In such a case it appears to make more sense to ignore the existing
release body should it be currently
nullinstead of implicitlyconverting it to a string for the updated release body.