Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate to typescript #253

Merged
merged 10 commits into from Nov 25, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 13 additions & 5 deletions .eslintrc
@@ -1,20 +1,29 @@
{
"extends": ["airbnb-base", "plugin:jasmine/recommended", "prettier"],
"plugins": ["jasmine", "prettier"],
"extends": [
"eslint:recommended",
"plugin:@typescript-eslint/eslint-recommended",
"plugin:@typescript-eslint/recommended",
mindhells marked this conversation as resolved.
Show resolved Hide resolved
"plugin:jasmine/recommended",
"prettier"
],
"parser": "@typescript-eslint/parser",
"plugins": ["jasmine", "@typescript-eslint", "prettier"],
"rules": {
"@typescript-eslint/no-namespace": "off",
mindhells marked this conversation as resolved.
Show resolved Hide resolved
"@typescript-eslint/no-explicit-any": "off",
"@typescript-eslint/ban-ts-comment": "off",
"prettier/prettier": [
"error",
{
"singleQuote": true,
"trailingComma": "none",
"printWidth": 100,
"semi": true,
"parser": "babel"
"parser": "typescript"
}
],
"jasmine/no-spec-dupes": ["warn", "branch"],
"jasmine/no-suite-dupes": ["warn", "branch"],

"valid-jsdoc": [
"warn",
{
Expand All @@ -34,6 +43,5 @@
"comma-dangle": ["warn", "never"],
"consistent-return": "off",
"no-restricted-properties":"off"

}
}
2 changes: 1 addition & 1 deletion .github/workflows/node.js.yml
Expand Up @@ -16,7 +16,7 @@ jobs:

strategy:
matrix:
node-version: [12.x, 14.x, 16.x, 18.x]
node-version: [16.x, 18.x, 20.x]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/

steps:
Expand Down
4 changes: 2 additions & 2 deletions .gitignore
@@ -1,6 +1,6 @@
node_modules
npm-debug.log
docs
lib
dist
.eslintcache
.npmrc
.npmrc
12 changes: 0 additions & 12 deletions babel.config.cjs.json

This file was deleted.

13 changes: 0 additions & 13 deletions babel.config.json

This file was deleted.

4 changes: 2 additions & 2 deletions fixup
Copy link

@rchl rchl Nov 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be something from before but I wonder what's the reasoning for adding those package.json files in the first place? I'm pretty sure that those don't really have any effect since it's the package's main package.json that decides whether something is an esm or commonjs module.

@@ -1,10 +1,10 @@
cat >lib/cjs/package.json <<!EOF
cat >dist/cjs/package.json <<!EOF
{
"type": "commonjs"
}
!EOF

cat >lib/esm/package.json <<!EOF
cat >dist/esm/package.json <<!EOF
{
"type": "module"
}
Expand Down
97 changes: 0 additions & 97 deletions index.d.ts

This file was deleted.

4 changes: 0 additions & 4 deletions index.js

This file was deleted.