Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/fix baseline traefik config #2

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

SuperITMan
Copy link
Contributor

@SuperITMan SuperITMan commented Sep 19, 2022

As mentioned in docker/compose#9570, - character is no longer supported in ".env".

Due to this issue, we can no longer start the baseline with docker-compose. We receive the following error:

$ docker-compose up -d

unexpected character "-" in variable name near "TRAEFIK_CERTIFICATESRESOLVERS_lets-encrypt_ACME_EMAIL=postmaster@example.com\n\n\n#Choose one of the challenges : TLS or DNS \n#when you choose one, the other method have to be set on 'false' \n\n#      TLS Challenge\n\nTRAEFIK_CERTIFICATESRESOLVERS_lets-encrypt_ACME_TLSCHALLENGE=true\n\n\n\n#                                            #This is for the dns Challenge, see https://doc.traefik.io/traefik/user-guides/docker-compose/acme-dns/\n#                                            #On some instances, I use DNS challenge in order to have wildcard certificates \n#                                            #If you're also using OVH : https://medium.com/nephely/configure-traefik-for-the-dns-01-challenge-with-ovh-as-dns-provider-c737670c0434\n\n\n#TRAEFIK_CERTIFICATESRESOLVERS_lets-encrypt_ACME_CASERVER=https://acme-v02.api.letsencrypt.org/directory  \n#TRAEFIK_CERTIFICATESRESOLVERS_lets-encrypt_ACME_DNSCHALLENGE=TRUE\n#TRAEFIK_CERTIFICATESRESOLVERS_lets-encrypt_ACME_DNSCHALLENGE_PROVIDER=ovh\n#TRAEFIK_CERTIFICATESRESOLVERS_lets-encrypt_ACME_DNSCHALLENGE_DELAYBEFORECHECK=10\n#OVH_ENDPOINT=\n#OVH_APPLICATION_KEY=\n#OVH_APPLICATION_SECRET=\n#OVH_CONSUMER_KEY=\n\n\n\n\n\n\n\n                                                                ######################################\n                                                                #        Automatic updates           #\n                                                                ######################################\nWATCHTOWER_POLL_INTERVAL=3600\nWATCHTOWER_CLEANUP=TRUE\nWATCHTOWER_LABEL_ENABLE=TRUE\nWATCHTOWER_NOTIFICATIONS=slack\nWATCHTOWER_NOTIFICATION_SLACK_HOOK_URL=\"\"\nWATCHTOWER_NOTIFICATION_SLACK_IDENTIFIER=\"Docker updates - \"\n\nWATCHTOWER_NOTIFICATION_EMAIL_FROM=\nWATCHTOWER_NOTIFICATION_EMAIL_TO=\nWATCHTOWER_NOTIFICATION_EMAIL_SERVER=\nWATCHTOWER_NOTIFICATION_EMAIL_SERVER_PORT=\nWATCHTOWER_NOTIFICATION_EMAIL_SERVER_USER=\nWATCHTOWER_NOTIFICATION_EMAIL_SERVER_PASSWORD=\nWATCHTOWER_NOTIFICATION_EMAIL_SUBJECTTAG=(Docker updates)\nWATCHTOWER_NOTIFICATION_EMAIL_DELAY=2\n\n\n\n"

This can be reproduced like this:

  1. clone docker-instances repository
  2. go in baseline folder
  3. rename ".env.dist" in ".env"
  4. run docker-compose up -d

This PR contains a BREAKING CHANGE regarding the variable names in the ".env" file.
The following variables MUST be renamed in .env file:

  • TRAEFIK_CERTIFICATESRESOLVERS_lets-encrypt_ACME_EMAIL -> TRAEFIK_ACME_EMAIL
  • TRAEFIK_CERTIFICATESRESOLVERS_lets-encrypt_ACME_TLSCHALLENGE -> TRAEFIK_ACME_TLSCHALLENGE
  • TRAEFIK_CERTIFICATESRESOLVERS_lets-encrypt_ACME_CASERVER -> TRAEFIK_ACME_CASERVER
  • TRAEFIK_CERTIFICATESRESOLVERS_lets-encrypt_ACME_DNSCHALLENGE -> TRAEFIK_ACME_DNSCHALLENGE
  • TRAEFIK_CERTIFICATESRESOLVERS_lets-encrypt_ACME_DNSCHALLENGE_PROVIDER -> TRAEFIK_ACME_DNSCHALLENGE_PROVIDER
  • TRAEFIK_CERTIFICATESRESOLVERS_lets-encrypt_ACME_DNSCHALLENGE_DELAYBEFORECHECK -> TRAEFIK_ACME_DNSCHALLENGE_DELAYBEFORECHECK

@SuperITMan SuperITMan force-pushed the bugfix/fix-baseline-traefik-config branch from 6022d06 to c7a3321 Compare September 19, 2022 15:12
More information about CLI arguments:
https://doc.traefik.io/traefik/reference/static-configuration/cli/

BREAKING CHANGE:

The following variables MUST be renamed in .env file:
- TRAEFIK_CERTIFICATESRESOLVERS_lets-encrypt_ACME_EMAIL -> TRAEFIK_ACME_EMAIL
- TRAEFIK_CERTIFICATESRESOLVERS_lets-encrypt_ACME_TLSCHALLENGE -> TRAEFIK_ACME_TLSCHALLENGE
- TRAEFIK_CERTIFICATESRESOLVERS_lets-encrypt_ACME_CASERVER -> TRAEFIK_ACME_CASERVER
- TRAEFIK_CERTIFICATESRESOLVERS_lets-encrypt_ACME_DNSCHALLENGE -> TRAEFIK_ACME_DNSCHALLENGE
- TRAEFIK_CERTIFICATESRESOLVERS_lets-encrypt_ACME_DNSCHALLENGE_PROVIDER -> TRAEFIK_ACME_DNSCHALLENGE_PROVIDER
- TRAEFIK_CERTIFICATESRESOLVERS_lets-encrypt_ACME_DNSCHALLENGE_DELAYBEFORECHECK -> TRAEFIK_ACME_DNSCHALLENGE_DELAYBEFORECHECK
@SuperITMan SuperITMan force-pushed the bugfix/fix-baseline-traefik-config branch from c7a3321 to 746e4ad Compare September 19, 2022 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant