feat: allow use in workspaces #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously, vite-jest assumed process.cwd() would contain node_modules in workspace environments, a parent directory may contain node_modules now, vite-jest will work in either setup
|
it appears vitejs/vite#4061 was included in vite@2.4.0 so maybe the PR here is to remove those lines entirely? |
added 2 commits
July 12, 2021 14:12
fixed in vitejs/vite#4061 and released v2.4.0
changed in vitejs/vite#4061 and released in v2.4.0
sodatea
approved these changes
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously, vite-jest assumed process.cwd() would contain node_modules
in workspace environments, a parent directory may contain node_modules
now, vite-jest will work in either setup
my project setup looks like:
if
workspace-a/package.jsonhad a test scriptvite-jestand was run from the root (i.e.npm run test --workspace workspace-a), it would attempt to write toworkspace-a/node_modules/vite/dist/clientwhich did not exist. now, it will correctly write tonode_modules/vite/dist/clienteven thoughprocess.cwd()isworkspace-a.