bump base gem versions #122
Conversation
rails5-deps/2.3.6/Dockerfile
Outdated
| @@ -1,40 +0,0 @@ | |||
| FROM socrata/ruby:2.3.6 | |||
There was a problem hiding this comment.
Hey, I see these files accidentally ended up multiple PRs. Are they now deleted locally so that doesn't keep happening?
|
@JoeNunnelley Should we close this PR or is it still mergeable? |
|
@rantler given updated knowledge I think it needs to be updated. Have to have both 1.x and 2.x bundler installed for compatibility. I'll update ASAP and get it merged. its a little bit involved to update these base images because it forces the rebuild of downwind images that we use to build things so it has to be coordinated. |
|
@rantler can you look at this again. I've changed each of these to now have an update rubygems and to (where appropriate) have both a 1.x and 2.x bundler installed (for backwards compat). |
ruby/2.3.6/Dockerfile
Outdated
| @@ -97,6 +97,7 @@ RUN set -ex \ | |||
| \ | |||
| && gem update --system "$RUBYGEMS_VERSION" \ | |||
| && gem install bundler --version "$BUNDLER_VERSION" --force \ | |||
| && gem install bundler | |||
There was a problem hiding this comment.
Nit: This should probably be indented the same as the neighboring lines.
| # skip installing gem documentation | ||
| RUN echo 'gem: --no-rdoc --no-ri --no-document' >> "/etc/gemrc" && \ | ||
| gem install bundler -v 1.17 --no-document | ||
| gem update --system && \ |
There was a problem hiding this comment.
Nit: We're use two different styles in these different Dockerfiles:
# This one
gem update --system && \
gem install bundler && \
# And this one
&& gem install bundler --version "$BUNDLER_VERSION" --force \
&& gem install bundler
It's not a huge deal, but it would be nice to be consistent.
ruby/2.5.0/Dockerfile
Outdated
| @@ -97,6 +97,7 @@ RUN set -ex \ | |||
| \ | |||
| && gem update --system "$RUBYGEMS_VERSION" \ | |||
| && gem install bundler --version "$BUNDLER_VERSION" --force \ | |||
| && gem install bundler \ | |||
ruby/2.5.3/Dockerfile
Outdated
| @@ -97,6 +97,7 @@ RUN set -ex \ | |||
| \ | |||
| && gem update --system "$RUBYGEMS_VERSION" \ | |||
| && gem install bundler --version "$BUNDLER_VERSION" --force \ | |||
| && gem install bundler \ | |||
There was a problem hiding this comment.
Nit: Indentation. Sorry 😬 This is true in several files in this PR.
py3_ruby/Dockerfile
Outdated
| gem install bundler -v 1.17 | ||
| gem update --system && \ | ||
| gem install bundler --no-document -v 1.17.3 && \ | ||
| gem install bundler --no-document |
There was a problem hiding this comment.
We should probably be explicit about this version as well. This is the version 2.x of bundler, right?
ruby/2.3.5/Dockerfile
Outdated
| @@ -97,6 +97,7 @@ RUN set -ex \ | |||
| \ | |||
| && gem update --system "$RUBYGEMS_VERSION" \ | |||
| && gem install bundler --version "$BUNDLER_VERSION" --force \ | |||
| && gem install bundler \ | |||
There was a problem hiding this comment.
I recommend explicitly specifying the version of the newer bundler in these installs.
|
this is quite out of date given changes marc has been making. closing and will open a new PR if necessary |
so I'm bumping bundler from 1.17 to 1.17.3 to get a fix for a bug that is affecting storyteller. rubygems/bundler#6761
also bumping the rubygems version to the latest 2.x version so they are all uniform.