Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow accessing http://127.0.0.1 from https page #506

Closed
wants to merge 1 commit into from
Closed

fix: allow accessing http://127.0.0.1 from https page #506

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/main.js
View file
Open in desktop
Expand Up @@ -74,7 +74,7 @@ function SockJS(url, protocols, options) {
throw new SyntaxError("The URL's scheme must be either 'http:' or 'https:'. '" + parsedUrl.protocol + "' is not allowed.");
}

var secure = parsedUrl.protocol === 'https:';
var secure = parsedUrl.protocol === 'https:' || parsedUrl.hostname === '127.0.0.1';
// Step 2 - don't allow secure origin with an insecure protocol
if (loc.protocol === 'https:' && !secure) {
throw new Error('SecurityError: An insecure SockJS connection may not be initiated from a page loaded over HTTPS');
Expand Down