Fix incorrect return types. Fixes #275. #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioquatix
requested review from
bryanp,
chuckremes,
olleolleolle,
rawrafox and
tarcieri
olleolleolle
approved these changes
Jul 30, 2021
tarcieri
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to #275,
libevimplementation of uring has some "syntax errors", as in it declares some return type but doesn't return anything.I checked and this is superficial, as in there were no cases where the (undefined) return value was ever used.
There is no update to
libevyet with these fixes, but a quick check upstream shows that they are fixed already.So I manually fixed the code by hand as a short term solution.
cc @tyan-boot
Types of Changes
Testing