Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing return statement in function returning non-void #275

Closed
tyan-boot opened this issue Jul 29, 2021 · 6 comments
Closed

Missing return statement in function returning non-void #275

tyan-boot opened this issue Jul 29, 2021 · 6 comments

Comments

@tyan-boot
Copy link

in ext/libev/ev_iouring.c, iouring_sqe_submit and iouring_internal_destroy function returning non-void but no return statement, cause build failed with

../libev/ev_iouring.c:300:1: error: no return statement in function returning non-void [-Werror=return-type]
  300 | }
      | ^
../libev/ev_iouring.c: In function ‘iouring_internal_destroy’:
../libev/ev_iouring.c:331:1: error: no return statement in function returning non-void [-Werror=return-type]
  331 | }

OS: openSUSE tumbleweed

@ioquatix
Copy link
Member

This looks like an issue with libev which we pull in. Maybe it is fixed in an update of libev. I will check.

ioquatix added a commit that referenced this issue Jul 29, 2021
@ioquatix
Copy link
Member

I checked the latest release of libev and it's an upstream bug. I've manually fixed the code in question.

@ioquatix
Copy link
Member

@tyan-boot do you have time to test this fix? It would be really helpful, I'm swamped.

@tyan-boot
Copy link
Author

@ioquatix sorry i have no ruby experience, but i run rake clean; rake compile in my openSUSE tumbleweed with e13165c, it successful generate tmp/x86_64-linux-gnu/stage/lib/nio4r_ext.so, i guess it gets fixed?

@Adriankhl
Copy link

Can we have a bug fix release for this?

@ioquatix
Copy link
Member

ioquatix commented Aug 3, 2021

Okay, I released v2.5.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants