-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow using custom endpoints for Async::HTTP::Internet #51
base: main
Are you sure you want to change the base?
Conversation
I agree with your assessment, but expanding the interface in this direction I need a little bit of time to think about it. |
The thing is I want to add support of SSL options (https://github.com/lostisland/faraday/blob/master/lib/faraday/options/ssl_options.rb) to
What approach do you think is better? Should I try going with the first one to avoid changing |
Can you make a subclass and add the appropriate hooks so you can configure the SSL to your requirements in the faraday adapter? |
I guess that would be almost the same as the first approach, as most of the |
Can we expose the right internal hooks for Do you imagine all clients would use the same SSL settings? I imagine something like:
Or something like that (those names/methods had all of 30 seconds of brain power). When you have specific SSL state, does it impact all connections or just some specific ones? |
Well if we are talking about the faraday use-case, SSL can be configured only per One way this could be configured in
or a separate method:
And then use that instance variable to build the endpoint:
Implementing the SSL options per-host will be trickier, as the actual per-host |
any news on this PR? i was trying to set SSL options today also and found this PR |
This PR introduces changes that allow passing custom
Async::HTTP::Endpoint
toAsync::HTTP::Internet
. This could be useful for example when we need to provide custom SSL options to requests.