Allow `Async::HTTP::Internet` methods to accept `URI::HTTP` objects. #118

postmodern · 2023-04-16T09:56:46Z

URI::HTTP objects do not define a to_str method, so call to_s on the uri instead.

Types of Changes

Bug fix.

Contribution

I added tests for my changes.
I tested my changes locally.
I agree to the Developer's Certificate of Origin 1.1.

* `URI::HTTP` objects do not define a `to_str` method, so use `to_s` instead.

ioquatix · 2023-04-16T11:17:22Z

This seems reasonable to me, but I just wonder why it was to_str in the first place.

Allow Async::HTTP::Internet methods to accept URI::HTTP objects.

3b7b1b6

* `URI::HTTP` objects do not define a `to_str` method, so use `to_s` instead.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow `Async::HTTP::Internet` methods to accept `URI::HTTP` objects. #118

Allow `Async::HTTP::Internet` methods to accept `URI::HTTP` objects. #118

postmodern commented Apr 16, 2023

ioquatix commented Apr 16, 2023

Allow Async::HTTP::Internet methods to accept URI::HTTP objects. #118

Are you sure you want to change the base?

Allow Async::HTTP::Internet methods to accept URI::HTTP objects. #118

Conversation

postmodern commented Apr 16, 2023

Types of Changes

Contribution

ioquatix commented Apr 16, 2023

Allow `Async::HTTP::Internet` methods to accept `URI::HTTP` objects. #118

Allow `Async::HTTP::Internet` methods to accept `URI::HTTP` objects. #118