Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add https.Server to accepted types #4351

Closed
wants to merge 1 commit into from
Closed

Add https.Server to accepted types #4351

wants to merge 1 commit into from

Commits on Apr 25, 2022

  1. ### The kind of change this PR does introduce 

    * [x] a bug fix
* [ ] a new feature
* [ ] an update to the documentation
* [ ] a code change that improves performance
* [ ] other

### Current behavior
Currently you can't attach a https server to the socket.io instance. You would first need to cast it to any and then to http.Server if you want to use it

### New behavior
Socket.io should now also accept https.Server

### Other information (e.g. related issues)
    @h110m
    h110m committed Apr 25, 2022
    Copy the full SHA
    6507d17 View commit details
    Browse the repository at this point in the history