Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: add base64-arraybuffer as prod dependency
The dependency was previously only listed as dev dependency, so that it was not included when installing the server (the "engine.io" package, which does not require it) and was explicitly included by the client (the "engine.io-client" package, which needs it for the browser build). But it failed with yarn v2, due to its stricter package boundaries: > ERROR in ../../../.yarn/cache/engine.io-parser-npm-4.0.1-6bdb879e8a-3b71ef8b5a.zip/node_modules/engine.io-parser/lib/decodePacket.browser.js 7:18-47 > Module not found: Error: engine.io-parser tried to access base64-arraybuffer, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound. > Required package: base64-arraybuffer (via "base64-arraybuffer") > Required by: engine.io-parser@npm:4.0.1 (via xxx/.yarn/cache/engine.io-parser-npm-4.0.1-6bdb879e8a-3b71ef8b5a.zip/node_modules/engine.io-parser/lib/) Related: - https://dev.to/arcanis/introducing-yarn-2-4eh1#strict-package-boundaries - #116
- Loading branch information