fix: use named export for globalThis shim (#688)

Default export of globalThis seems to have a problem in the "browser" field when the library is loaded asynchronously with webpack.
socketio · May 2, 2022 · 32878ea · 32878ea
1 parent 8437600
commit 32878ea
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 7 deletions.
diff --git a/lib/globalThis.browser.ts b/lib/globalThis.browser.ts
@@ -1,4 +1,4 @@
-export default (() => {
+export const globalThisShim = (() => {
   if (typeof self !== "undefined") {
     return self;
   } else if (typeof window !== "undefined") {

diff --git a/lib/globalThis.ts b/lib/globalThis.ts
@@ -1 +1 @@
-export default global;
+export const globalThisShim = global;
diff --git a/lib/transports/polling.ts b/lib/transports/polling.ts
@@ -7,7 +7,7 @@ import XMLHttpRequest from "./xmlhttprequest.js";
 import { Emitter } from "@socket.io/component-emitter";
 import { SocketOptions } from "../socket.js";
 import { installTimerFunctions, pick } from "../util.js";
-import globalThis from "../globalThis.js";
+import { globalThisShim as globalThis } from "../globalThis.js";
 
 const debug = debugModule("engine.io-client:polling"); // debug()
 

diff --git a/lib/transports/websocket-constructor.browser.ts b/lib/transports/websocket-constructor.browser.ts
@@ -1,4 +1,4 @@
-import globalThis from "../globalThis.js";
+import { globalThisShim as globalThis } from "../globalThis.js";
 
 export const nextTick = (() => {
   const isPromiseAvailable =

diff --git a/lib/transports/xmlhttprequest.browser.ts b/lib/transports/xmlhttprequest.browser.ts
@@ -1,7 +1,7 @@
 // browser shim for xmlhttprequest module
 
 import { hasCORS } from "../contrib/has-cors.js";
-import globalThis from "../globalThis.js";
+import { globalThisShim as globalThis } from "../globalThis.js";
 
 export default function(opts) {
   const xdomain = opts.xdomain;

diff --git a/lib/util.ts b/lib/util.ts
@@ -1,4 +1,4 @@
-import globalThis from "./globalThis.js";
+import { globalThisShim as globalThis } from "./globalThis.js";
 
 export function pick(obj, ...attr) {
   return attr.reduce((acc, k) => {

diff --git a/lib/xmlhttprequest.ts b/lib/xmlhttprequest.ts
@@ -1,7 +1,7 @@
 // browser shim for xmlhttprequest module
 
 import { hasCORS } from "./contrib/has-cors.js";
-import globalThis from "./globalThis.js";
+import { globalThisShim as globalThis } from "./globalThis.js";
 
 export default function(opts) {
   const xdomain = opts.xdomain;