wip: introduce k8s service testing #114
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmars
reviewed
Jan 5, 2022
There was a problem hiding this comment.
First and foremost: This is fricken awesome!
A thought: I'm wondering if we should separate concerns here a bit:
- Keep the scraper as a thing that scrapes lists of services
- Introduce a service discovery interface w/k8s implementation, as a thing which configures a Scraper interface with a list of discovered services.
That keeps options open if one wants to add extra services. Thinking of how prometheus is configured -- you can specify scrape targets directly by host:port/path, and also set up SD to import additional scrape targets from k8s and other sources automatically.
Instead of depending on a config file, we can use Kubernetes' go-library to loop over services and identify viable services by label (`registry-web` for now). Added a few TODOs too that should be addressed. ALSO: - update docker image to 1.17
Todai88
force-pushed
the
wip/introduce-k8s-service-testing
branch
from
58b28de
to
a68482f
Compare
|
I love this! I like the idea of allowing static vs. dynamic discovery here as a separate setting in VU. A great jumping off point to be sure though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be mindful that this very much is a PoC / WIP.
Instead of depending on a config file, we can use Kubernetes' go-library to
loop over services and identify viable services by label (
registry-webfor now).Added a few TODOs too that should be addressed.