Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add descriptor for non-supported coverage and fix duplicate languages #183

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

z4ce
Copy link

@z4ce z4ce commented Mar 19, 2024

What this does

Right now coverage blocks where isSupported=False and type=FAILED_PARSING end up in the coverage section of the report and cannot be differentiated from success. This change just adds the type of coverage in brackets if isSupported is false.

Example input snippet:

"properties": {
        "coverage": [
          {
            "isSupported": true,
            "lang": "XML",
            "files": 3,
            "type": "SUPPORTED"
          },
          {
            "isSupported": true,
            "lang": "HTML",
            "files": 13,
            "type": "SUPPORTED"
          },
          {
            "isSupported": true,
            "lang": "Java",
            "files": 39,
            "type": "SUPPORTED"
          },
          {
            "isSupported": false,
            "lang": "Java",
            "files": 1,
            "type": "FAILED_PARSING"
          }
        ]
      }

Right now it renders as

image

After this PR it renders as:
image

Here is an example file with a file that has failed to parse:
test.json

Right now coverage blocks where isSupported=False and
type=FAILED_PARSING end up in the coverage section of the report
and cannot be differentiated from success. This change just
adds the type of coverage in brackets if the type is not supported.

Signed-off-by: Ian Zink <zforce@gmail.com>
@z4ce z4ce requested a review from a team as a code owner March 19, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant