Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused docker file #165

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dragos-cojocari
Copy link
Contributor

Remove unused Dockerfile.

Remove unused Dockerfile.
@dragos-cojocari dragos-cojocari requested a review from a team as a code owner July 26, 2023 13:08
@PeterSchafer
Copy link
Contributor

I'm not completely sure it is unused. Also there is the docker-entrypoint.sh file which would be obsolete if we remove the Dockerfile. I will take a closer look.

@dragos-cojocari
Copy link
Contributor Author

I'm not completely sure it is unused. Also there is the docker-entrypoint.sh file which would be obsolete if we remove the Dockerfile. I will take a closer look.

Thanks Peter, appreciated. Neither the GH Workflows nor the CircleCI are building/using the Docker but there may be other locations. But yeah, if we deprecate the Dockerfile the .sh needs to go to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants