Add ARM64 support #942
Add ARM64 support #942
Conversation
Signed-off-by: odidev <odidev@puresoftware.com>
| mkdir -vp ~/.docker/cli-plugins/ | ||
| curl --silent -L --output ~/.docker/cli-plugins/docker-buildx https://github.com/docker/buildx/releases/download/v0.6.3/buildx-v0.6.3.linux-amd64 | ||
| chmod a+x ~/.docker/cli-plugins/docker-buildx | ||
| docker run -it --rm --privileged tonistiigi/binfmt --install all |
There was a problem hiding this comment.
Hey @odidev what does this line do?
There was a problem hiding this comment.
Hi @ivanstanev,
Since Circle-CI runner supports only amd64 platform, these lines add docker buildx which is required to build and release docker images for multiple architectures.
There was a problem hiding this comment.
I see but what does tonistiigi/binfmt do and why does it need to run privileged?
There was a problem hiding this comment.
Hi @ivanstanev,
The command enables docker buildx builder to support multiple architecture builds. You can refer official Circle-CI blog to build docker images for multiple architectures here. I have added same steps.
|
Hey @odidev we're not comfortable merging this, we prefer the multi-arch support to become native to the Docker toolkit rather than running external containers and emulators to get this working. Perhaps it's possible to achieve something similar by using ARM build machines in CircleCI. For now we're closing this until we have a more native solution! |
What this does
This PR intends to add support for ARM64 in Dockerfile, config.yml and yaml deployment files to be able use and detect arm64 as well as amd64 nodes.
Relevant ticket: #928