Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instrumentation): derive category vector CLI-307 #166

Merged
merged 1 commit into from May 16, 2024

Conversation

mgyorke
Copy link
Contributor

@mgyorke mgyorke commented May 13, 2024

This PR adds the ParseCliArgs function to parse command-line arguments into product/command/flag categories as per the RFC. The function uses whitelists and known commands to determine the correct categories, defaulting to "oss" if no product is explicitly provided.

@mgyorke mgyorke marked this pull request as ready for review May 15, 2024 10:50
@mgyorke mgyorke requested a review from a team as a code owner May 15, 2024 10:50
@mgyorke mgyorke force-pushed the feat/derive-category-vector-CLI-307 branch from c329606 to 222748d Compare May 15, 2024 11:06
@mgyorke mgyorke changed the title feat(instrumentation): derive category vector feat(instrumentation): derive category vector CLI-307 May 15, 2024
@mgyorke mgyorke force-pushed the feat/derive-category-vector-CLI-307 branch from 7adecea to a5d37e7 Compare May 15, 2024 15:34
@mgyorke mgyorke force-pushed the feat/derive-category-vector-CLI-307 branch from ebc2090 to 2f246c0 Compare May 16, 2024 09:39
Copy link
Contributor

@PeterSchafer PeterSchafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PeterSchafer PeterSchafer merged commit b1d99f4 into main May 16, 2024
5 checks passed
@PeterSchafer PeterSchafer deleted the feat/derive-category-vector-CLI-307 branch May 16, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants