feat: export TokenColor helpers #147
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisislawatts
force-pushed
the
feat/export-color-token-helprs
branch
from
956ff78
to
2c7e219
Compare
thisislawatts
force-pushed
the
feat/export-color-token-helprs
branch
from
2c7e219
to
081f8c2
Compare
| } | ||
| } | ||
|
|
||
| func TokenColor(name string) lipgloss.TerminalColor { |
There was a problem hiding this comment.
Question: Why do we need this in the public API of the application framework, while it only applies to CLI ASCII escaped UIs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new
TokenColorhelper for resolving a token name to a specific Terminal.Color value. This can be adopted by any extensions rendering output to terminal.Benefits:
Questions:
go-application-frameworkhave knowledge of the Terminal Colours? In theory folks could be building any kind of application with these workflows