feat: progress tracker [IDE-175] #130
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,56 +1,56 @@ | |||
| module github.com/snyk/go-application-framework | |||
|
|
|||
| go 1.18 | |||
| go 1.21 | |||
There was a problem hiding this comment.
@PeterSchafer this should be ok, now that CLI is using a higher go version, right?
|
|
||
| func (t *Tracker) EndWithMessage(message string) { | ||
| if t.finished { | ||
| panic("Called end progress twice. This breaks LSP in Eclipse fix me now and avoid headaches later") |
There was a problem hiding this comment.
Is this something we should fix now? It's a bit annoying to mention LSP and Eclipse, plus not ideal to cause a panic in the CLI although if the function is used correctly we shouldn't cause it. It might be better to log an error instead and return early maybe?
bastiandoetsch
approved these changes
Mar 13, 2024
teodora-sandu
force-pushed
the
feat/progress-tracker
branch
from
97ffa8e
to
e2f7830
Compare
teodora-sandu
force-pushed
the
feat/progress-tracker
branch
from
e2f7830
to
22c084c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is extracting the progress tracker to GAF so that it can be used by the CLI too. The LS uses it to update the display for our IDEs, the CLI could use it to log or do whatever sort of updates they want (for example, update the progress bar).
The changes in
snyk-lsare in snyk/snyk-ls#465.