test: user journey tests for Go based snyk code test #5172
+3,677
−183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
j-luong
force-pushed
the
chore/CLI-225_validateNativeSnykCode
branch
7 times, most recently
from
c053d34
to
6534150
Compare
| const EXIT_CODE_SUCCESS = 0; | ||
| const EXIT_CODE_ACTION_NEEDED = 1; | ||
| const EXIT_CODE_FAIL_WITH_ERROR = 2; | ||
| const EXIT_CODE_NO_SUPPORTED_FILES = 3; | ||
|
|
||
| describe('code', () => { | ||
| describe('snyk code test', () => { |
There was a problem hiding this comment.
suggestion: move beforeall/after hooks into dedicated describe blocks for user journey tests
| expect(code).toBe(EXIT_CODE_ACTION_NEEDED); | ||
|
|
||
| const jsonOutput = JSON.parse(stdout); | ||
| expect(jsonOutput).toMatchSchema(SARIF_SCHEMA); |
There was a problem hiding this comment.
praise: Very happy to see us validating against the schema rather than the contents 💜
| // INTERNAL_SNYK_CODE_IGNORES_ENABLED: 'true', | ||
| // }, | ||
| // } | ||
| ]; |
There was a problem hiding this comment.
issue: We are missing mocked responses for the new analysis endpoints.
thisislawatts
force-pushed
the
chore/CLI-225_validateNativeSnykCode
branch
from
6534150
to
a0ffe17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Risk assessment
Low - Changes to test files, no functional changes
Pull Request Submission
Please check the boxes once done.
The pull request must:
feat:orfix:, others might be used in rare occasions as well, if there is no need to document the changes in the release notes. The changes or fixes should be described in detail in the commit message for the changelog & release notes.Pull Request Review
All pull requests must undergo a thorough review process before being merged.
The review process of the code PR should include code review, testing, and any necessary feedback or revisions.
Pull request reviews of functionality developed in other teams only review the given documentation and test reports.
Manual testing will not be performed by the reviewing team, and is the responsibility of the author of the PR.
For Node projects: It’s important to make sure changes in
package.jsonare also affectingpackage-lock.jsoncorrectly.If a dependency is not necessary, don’t add it.
When adding a new package as a dependency, make sure that the change is absolutely necessary. We would like to refrain from adding new dependencies when possible.
Documentation PRs in gitbook are reviewed by Snyk's content team. They will also advise on the best phrasing and structuring if needed.
Pull Request Approval
Once a pull request has been reviewed and all necessary revisions have been made, it is approved for merging into
the main codebase. The merging of the code PR is performed by the code owners, the merging of the documentation PR
by our content writers.
What does this PR do?
This PR changes the structure of the
snyk codetests intest/jest/acceptance/snyk-code/snyk-code.spec.ts. It:Where should the reviewer start?
Reviewing the changes to the test file
How should this be manually tested?
make clean buildTEST_SNYK_COMMAND=./binary-releases/<snyk-binary> npx jest ././test/jest/acceptance/snyk-code/snyk-code.spec.tsAny background context you want to provide?
What are the relevant tickets?
Screenshots
Additional questions