Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1367711: Remove incorrect error log message. #1942

Merged
merged 1 commit into from
May 17, 2024

Conversation

sfc-gh-jrose
Copy link
Contributor

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1367711

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    SNOW-1269820: Structured Type support for pandas and iceberg. #1907 introduced a new log line that I was using to debug an issue related to timestamp scale. This change should not have been included in that PR and only adds noise.

Copy link

@rajathpatel23 rajathpatel23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this promptly

@sfc-gh-jrose sfc-gh-jrose marked this pull request as ready for review May 17, 2024 17:31
@sfc-gh-jrose sfc-gh-jrose merged commit b05f25a into main May 17, 2024
93 checks passed
@sfc-gh-jrose sfc-gh-jrose deleted the jrose_snow_1367711_too_much_logging branch May 17, 2024 17:36
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants