Use the limited C api #1827
Draft
Use the limited C api #1827
+850
−396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ResultValue shouldn't be in a `shared_ptr`, and `UniqueRef::release()` shouldn't have a period of time where it points at something that might have a refcount of 0.
These are extremely tricky to do in C++, so keeping the exact same log lines is probably not worth the effort. The other issue is that the limited API doesn't specify how to use module state from a function. There are some methods in 3.10+ (like `PyType_FromModuleAndSpec()`) which might help, but then we have the potential issue of subclasses being from a different module.
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
| @@ -321,6 +321,9 @@ jobs: | |||
| PYTEST_ADDOPTS: --color=yes --tb=short | |||
| TOX_PARALLEL_NO_SPINNER: 1 | |||
| shell: bash | |||
| - name: Debug - find files | |||
There was a problem hiding this comment.
I think this is not necessary anymore
| ], | ||
| language="c++", |
There was a problem hiding this comment.
I think long-term this should be a c file. Then all source files would either be C, or Python
| if sys.platform == "win32": | ||
| if not any("/std" not in s for s in ext.extra_compile_args): | ||
| ext.extra_compile_args.append("/std:c++17") | ||
| elif sys.platform == "linux" or sys.platform == "darwin": |
There was a problem hiding this comment.
Suggested change
| elif sys.platform == "linux" or sys.platform == "darwin": | |
| elif sys.platform in ("linux", "darwin"): |
| if not any("/std" not in s for s in ext.extra_compile_args): | ||
| ext.extra_compile_args.append("/std:c++17") | ||
| elif sys.platform == "linux" or sys.platform == "darwin": | ||
| if "std=" not in os.environ.get("CXXFLAGS", ""): |
There was a problem hiding this comment.
Since we are touching this code, we could rework this part so that CXXFLAGS wouldn't be read out of environment variable multiple times.
Comment on lines
+123
to
+125
| # sys.platform for linux used to return with version suffix, (i.e. linux2, linux3) | ||
| # After version 3.3, it will always be just 'linux' | ||
| # https://docs.python.org/3/library/sys.html#sys.platform |
There was a problem hiding this comment.
Suggested change
| # sys.platform for linux used to return with version suffix, (i.e. linux2, linux3) | |
| # After version 3.3, it will always be just 'linux' | |
| # https://docs.python.org/3/library/sys.html#sys.platform |
| return python, abi, plat | ||
|
|
||
| class MyBuildExt(build_ext): | ||
| def build_extension(self, ext): |
There was a problem hiding this comment.
Suggested change
| def build_extension(self, ext): | |
| def build_extension(self, ext) -> None: |
| extensions = get_extensions() | ||
|
|
||
| class MyBuildWheel(bdist_wheel): | ||
| def get_tag(self): |
There was a problem hiding this comment.
Suggested change
| def get_tag(self): | |
| def get_tag(self) -> Tuple[str, str, str]: |
This will probably need to be imported.
| @@ -32,11 +32,11 @@ extras = | |||
| sso: secure-local-storage | |||
| install_command = python -m pip install -U {opts} {packages} | |||
| external_wheels = | |||
There was a problem hiding this comment.
TODO: We should investigate whether we could retire this plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
(TODO)
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
This migrates
ArrowIteratorfrom Cython to a pure C++ implementation, using the limited C API.