Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused requirement for importlib-metadata #1807

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

akx
Copy link

@akx akx commented Nov 16, 2023

What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

None. It just removes a requirement that can't possibly be used since it'd only be used for Python < 3.8, but the library itself requires Python >= 3.8.

Fill out the following pre-review checklist:

  • I am adding a new automated test(s) to verify correctness of my new code
  • I am adding new logging messages
  • I am adding a new telemetry message
  • I am modifying authorization mechanisms
  • I am adding new credentials
  • I am modifying OCSP code
  • I am adding a new dependency

Please describe how your code solves the related issue.

It removes the unnecessary requirement line.

Copy link

github-actions bot commented Nov 16, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@akx

This comment was marked as outdated.

@sfc-gh-mkeller
Copy link
Collaborator

sfc-gh-mkeller commented Nov 17, 2023

I have read the CLA Document and I hereby sign the CLA

@akx please be careful, there were new lines at the end of your comment. The bot is very simple and will not handle whitespaces correctly. Please post a new comment with exactly what it expects.
I apologize for the inconvenience!

@akx
Copy link
Author

akx commented Nov 17, 2023

I have read the CLA Document and I hereby sign the CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants