Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test pr 1624 #1756

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

Test pr 1624 #1756

wants to merge 16 commits into from
+261 −200

Conversation

sfc-gh-sfan
Copy link
Contributor

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

sfc-gh-cconner and others added 16 commits June 30, 2023 12:14
@sfc-gh-cconner
Fixed issue reading issuer and subject from cert in diagnostic. Issue:
bf1a4f9 
#1536

Also capture any exception during diagnostics and raise them after
diagnostics complete
@sfc-gh-cconner
Update connection.py
377a97e 
Somehow a change I had didn't make it into the commit.  It's there now.
@sfc-gh-cconner
Update connection_diagnostic.py
7fbe515
@sfc-gh-cconner
Merge branch 'main' into fix_cert_check_for_diagnostics
e86b526
@sfc-gh-cconner
Updated the description for change log
9704d4a
@sfc-gh-cconner
Updated the description for change log and added Exception test
fd8372a
@sfc-gh-cconner
Merge branch 'snowflakedb:fix_cert_check_for_diagnostics' into fix_ce…
6d87637 
…rt_check_for_diagnostics
@sfc-gh-yqiu @sfc-gh-aling @sfc-gh-cconner
Implement thread safety during instantiation of TelemetryService (#1729)
7abca68 
* Implement thread safety during instantiation on TelemetryService

* Code and test cleanup

* Edited DESCRIPTION.md

* Update DESCRIPTION.md

Take Adam's suggestion

Co-authored-by: Adam Ling <adam.ling@snowflake.com>

---------

Co-authored-by: Adam Ling <adam.ling@snowflake.com>
@sfc-gh-aalam @sfc-gh-cconner
SNOW-872568: Fix retry oscp URL for private link (#1733)
d103b36
@sfc-gh-mkeller @sfc-gh-cconner
SNOW-893112 updated platformdirs usage (#1737)
15ddb29
@sfc-gh-mkeller @sfc-gh-cconner
SNOW-899912 patching out urllib3.contrib.pyopenssl deprecation warnin…
2edbe92 
…gs (#1735)
@sfc-gh-anavalos @sfc-gh-cconner
SNOW-921832: Bumped up PythonConnector PATCH version from 3.2.0 to 3.…
b07d95b 
…2.1 (#1740)
@sfc-gh-aling @sfc-gh-cconner
SNOW-923398: improve robustness in handling authentication response (#…
ced2921 
…1742)
@sfc-gh-cconner
Updated the description for change log
ab8101d
@sfc-gh-cconner
Updated the description for change log
742c00b
@sfc-gh-cconner
Updated the description for change log
75b4930
@sfc-gh-sfan sfc-gh-sfan mentioned this pull request Oct 6, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@sfc-gh-sfan @sfc-gh-cconner @sfc-gh-yqiu @sfc-gh-aalam @sfc-gh-mkeller @sfc-gh-anavalos @sfc-gh-aling