Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timeout log message #1753

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aneeshdurg
Copy link

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-923450: Misleading log message for query that times out #1738 1738

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    The debug message is more accurate and has a unique message depending on where the timer is being cancelled.

@aneeshdurg aneeshdurg mentioned this pull request Oct 5, 2023
7 tasks
@aneeshdurg
Copy link
Author

@sfc-gh-stan @sfc-gh-dszmolka I was recently reminded of this from the activity on the associated issue - can this PR be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SNOW-923450: Misleading log message for query that times out
2 participants