Add a merge gate as a reminder for necessary sp connector changes #1701
+22
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-jdu
force-pushed
the
jdu-sp-gate
branch
from
e627f67
to
2b27da0
Compare
sfc-gh-jdu
force-pushed
the
jdu-sp-gate
branch
from
f41e215
to
9b0da1e
Compare
sfc-gh-jdu
changed the title
sfc-gh-jdu
added
the
NO-CHANGELOG-UPDATES
sfc-gh-jdu
commented
Aug 17, 2023
| paths: | ||
| - 'src/snowflake/connector/cpp/**' | ||
| - 'src/snowflake/connector/*.py*' | ||
| - '!src/snowflake/connector/*ocsp*' |
There was a problem hiding this comment.
we can add more files here if they aren't useful for SP
sfc-gh-jdu
requested review from
a team,
sfc-gh-yixie and
sfc-gh-evandenberg
and removed request for
a team
sfc-gh-aalam
approved these changes
Aug 18, 2023
sfc-gh-sfan
reviewed
Aug 21, 2023
| jobs: | ||
| check_sp_change: | ||
| runs-on: ubuntu-latest | ||
| if: ${{!contains(github.event.pull_request.labels.*.name, 'NO-CHANGE-IN-SP')}} |
There was a problem hiding this comment.
What happens for changes that need to be ported? Should we check if the comment/description has a PR link of certain format?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we are changing certain files in connector, you will get a failed merge gate "Stored Procedure Change Check". If you think this change doesn't need to be ported to SP connector or you are already aware of it and created a PR, add
NO-CHANGE-IN-SPlabel to skip the merge gate.