Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test pr 1477 #1681

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Test pr 1477 #1681

wants to merge 9 commits into from
+93 −24

Conversation

sfc-gh-sfan
Copy link
Contributor

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-sfan sfc-gh-sfan mentioned this pull request Aug 3, 2023
Merged
7 tasks
malthe and others added 8 commits August 4, 2023 00:01
@malthe
Add support for specifying 'RSAPublicKey' instance instead of raw bytes
8c84a22 
This can be used to externalize the JWT encoding process.
@malthe
Add test for private key abstraction layer
60ed084
@malthe
Add 'isinstance' check to make sure private key has an expected type
a58dd81
@malthe
Revert method signature change
576778b 
Note that while this method does not require a private key, the change is
inconsequential because we're anyway expecting something that implements
a private key at the class level (either bytes or an abstract implementation)
@malthe
Be more specific in type error message
3216926
@malthe
Add failing test for non-bytes, non-RSAPrivateKey value
53ec754
@malthe
Fix linting issues
c66d883
@sfc-gh-sfan @malthe
add changelog
8d5e6b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sfc-gh-sfan @malthe