Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Darwin Version Tests #1580

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

sfc-gh-kdama
Copy link
Collaborator

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #1580 (7af6d59) into main (8b018cf) will decrease coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1580      +/-   ##
==========================================
- Coverage   82.48%   82.34%   -0.14%     
==========================================
  Files          62       62              
  Lines        8815     8815              
  Branches     1305     1305              
==========================================
- Hits         7271     7259      -12     
- Misses       1210     1221      +11     
- Partials      334      335       +1     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@@ -5,7 +5,11 @@
# - Versions to be tested should be passed in as the first argument, e.g: "3.7 3.8". If omitted 3.7-3.11 will be assumed.
# - This script uses .. to download the newest wheel files from S3

PYTHON_VERSIONS="${1:-3.7 3.8 3.9 3.10 3.11}"
if [[ "$arch" == "arm64" ]]; then
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch is undefined

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants