Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1335581 Decrease number of retires for OCSP #1129

Merged
merged 2 commits into from May 28, 2024

Conversation

sfc-gh-pfus
Copy link
Collaborator

@sfc-gh-pfus sfc-gh-pfus commented May 13, 2024

Description

SNOW-1335581 Exposed config values for retrying OCSP requests. Decreased default values.

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary

Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 75.43%. Comparing base (a0145ec) to head (aa90dfa).
Report is 1 commits behind head on master.

Files Patch % Lines
ocsp.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1129      +/-   ##
==========================================
- Coverage   75.44%   75.43%   -0.01%     
==========================================
  Files          53       53              
  Lines       11272    11285      +13     
==========================================
+ Hits         8504     8513       +9     
- Misses       2768     2772       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-1335581-decrease-number-of-ocsp-retries branch from 2e99320 to d97f9cd Compare May 15, 2024 12:39
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-1335581-decrease-number-of-ocsp-retries branch from aa0d2bb to 2f6ed6e Compare May 27, 2024 11:29
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-1335581-decrease-number-of-ocsp-retries branch from 2f6ed6e to aa90dfa Compare May 27, 2024 11:32
@sfc-gh-pfus sfc-gh-pfus marked this pull request as ready for review May 28, 2024 05:30
@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner May 28, 2024 05:30
@sfc-gh-pfus sfc-gh-pfus merged commit 6ee8545 into master May 28, 2024
37 of 38 checks passed
@sfc-gh-pfus sfc-gh-pfus deleted the SNOW-1335581-decrease-number-of-ocsp-retries branch May 28, 2024 08:47
@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants