Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1226624 Parameter to disable SAML URL check #1128

Merged
merged 1 commit into from May 14, 2024

Conversation

sfc-gh-ext-simba-jl
Copy link
Collaborator

Description

issue #942

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary

Copy link

codecov bot commented May 11, 2024

Codecov Report

Attention: Patch coverage is 93.54839% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 75.42%. Comparing base (c355711) to head (e26cc2f).

Files Patch % Lines
dsn.go 85.71% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1128      +/-   ##
==========================================
+ Coverage   75.40%   75.42%   +0.01%     
==========================================
  Files          53       53              
  Lines       11250    11266      +16     
==========================================
+ Hits         8483     8497      +14     
- Misses       2767     2769       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl marked this pull request as ready for review May 13, 2024 17:08
@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl requested a review from a team as a code owner May 13, 2024 17:08
@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl changed the title SNOW-1226624: Add parameter to disable SAML URL check SNOW-1226624 Parameter to disable SAML URL check May 13, 2024
@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl merged commit 7f760af into master May 14, 2024
38 checks passed
@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl deleted the 942-DisableSamlURLCheck branch May 14, 2024 17:38
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants