Check if the target is an object instead of an array to avoid deletin…

…g properties fixes jonschlinkert#35
snowbldr · Mar 26, 2022 · 2a24ab2 · 2a24ab2
1 parent 56a44ed
commit 2a24ab2
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/index.js b/index.js
@@ -145,7 +145,7 @@ const setValue = (target, path, value, options) => {
       break;
     }
 
-    if (typeof next === 'number' && !Array.isArray(obj[key])) {
+    if (typeof next === 'number' && (typeof obj[key] !== 'object' || obj[key] === null)) {
       obj = obj[key] = [];
       continue;
     }

diff --git a/test/test.js b/test/test.js
@@ -124,9 +124,15 @@ describe('set-value', () => {
     });
 
     it('should not delete number properties from an object', ()=>{
-      const o = {a: {0: 'foo', 1: 'bar'}}
+      const o = { a: { 0: 'foo', 1: 'bar' } }
       set(o, 'a.0', 'baz')
-      assert.deepEqual(o, {a: {0: 'baz', 1: 'bar'}})
+      assert.deepEqual(o, { a: { 0: 'baz', 1: 'bar' } })
+    })
+
+    it('should create an array if the target is null', ()=>{
+      const o = { a: null }
+      set(o, 'a.0', 'baz')
+      assert.deepEqual(o, { a: ['baz'] })
     })
 
     it('should create a deeply nested property if it does not already exist', () => {