Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ldap_company as a syncable field #14061

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

Godmartinz
Copy link
Collaborator

@Godmartinz Godmartinz commented Dec 19, 2023

Description

adds ldap_company as a syncable field. As this PR is written right now, we will create a Company off the name if it does not exist in our DB. This idea is fluid, and up for change according to @uberbrady

Fixes #14033

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

Copy link

what-the-diff bot commented Dec 19, 2023

PR Summary

  • Integration of Company model within LDAP sync command

    • The Company model is now used in the LDAP sync command, which allows the code to interact with company-specific data during the LDAP synchronization process.
  • Addition of ldap_company in Settings

    • A new setting called ldap_company has been added to the settings database, allowing users to specify the LDAP company attribute during the synchronization process.
  • Update in LDAP Settings User Interface

    • The LDAP settings page on the user interface has been updated to include the new LDAP Company field. This makes it easy for users to manage LDAP company settings directly from the UI.
  • Language File Update

    • The English language file for admin settings has been updated with the addition of ldap_company. This ensures that international users receive clear and accurate information about this new setting.
  • Addition of company field handling in Ldap Model

    • The method used for parsing and mapping LDAP attributes has been updated to handle the company field. This improvement ensures accurate and efficient synchronization of company data from LDAP.
  • Update in postLdapSettings Method

    • The method which handles the updating of LDAP settings has been updated to account for the new ldap_company field. This ensures that changes in company data can be properly stored and reflected in the system's settings.

@Godmartinz Godmartinz marked this pull request as ready for review March 11, 2024 21:40
@Godmartinz Godmartinz requested a review from snipe as a code owner March 11, 2024 21:40
@snipe
Copy link
Owner

snipe commented Mar 14, 2024

Does this PR add a company filter, or actually create a company based on the text in the field? We'd probably want to clarify that, and I'd be curious from @uberbrady if this is actually the behavior we'd want (unintended consequences, etc)

@akeshell
Copy link

May I ask when the new version of this function will be launched

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants