Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't project if you require Unpin. #90

Closed
wants to merge 2 commits into from
Closed

Don't project if you require Unpin. #90

wants to merge 2 commits into from

Commits on Mar 5, 2020

  1. Don't project if you require Unpin. 

    This doesn't make sense. For Unpin types, Pin does nothing, so Pin::new() is sufficient
and there is no need to project.

If it's projected, it's already pinned, so no need to call Pin::new().

Thus project and Pin::new together is always a code smell.
    @najamelan
    najamelan committed Mar 5, 2020
    Copy the full SHA
    78f28e3 View commit details
    Browse the repository at this point in the history

  2. Require Role::InternalStream to be Unpin and remove pin-project depen… 

    …dency.
    @najamelan
    najamelan committed Mar 5, 2020
    Copy the full SHA
    880022c View commit details
    Browse the repository at this point in the history