Gracefully handle invalid native root certificates #283
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, the
rustls::RootCertStore::add
method was used to add all the root certificates found byrustls_native_certs
crate. This is a problem when an ancient or invalid certificate is present in the native root store.rustls
documentation says the following:With this patch,
RootCertStore::add_parsable_certificates
is used instead for maximal compability with system store.