Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the echo server example to prevent ConnectionClosed error #189

Merged
merged 1 commit into from Sep 16, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 6 additions & 2 deletions examples/echo-server.rs
Expand Up @@ -10,7 +10,7 @@

use std::{env, io::Error};

use futures_util::StreamExt;
use futures_util::{future, StreamExt, TryStreamExt};
use log::info;
use tokio::net::{TcpListener, TcpStream};

Expand Down Expand Up @@ -42,5 +42,9 @@ async fn accept_connection(stream: TcpStream) {
info!("New WebSocket connection: {}", addr);

let (write, read) = ws_stream.split();
read.forward(write).await.expect("Failed to forward message")
// We should not forward messages other than text or binary.
read.try_filter(|msg| future::ready(msg.is_text() || msg.is_binary()))
.forward(write)
.await
.expect("Failed to forward messages")
}