Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uses of pin_project::project attribute #105

Merged
merged 1 commit into from Jun 7, 2020

Conversation

taiki-e
Copy link
Contributor

@taiki-e taiki-e commented Jun 5, 2020

pin-project will deprecate the project attribute due to some unfixable
limitations.

Refs: taiki-e/pin-project#225

Although the deprecation of the project attribute has not been released yet, this PR is submitted in advance to avoid the CI from being broken by deprecated warnings.

pin-project will deprecate the project attribute due to some unfixable
limitations.

Refs: taiki-e/pin-project#225
@sdroege
Copy link
Contributor

sdroege commented Jun 6, 2020

See also #90

@daniel-abramov daniel-abramov merged commit 317569d into snapview:master Jun 7, 2020
@daniel-abramov
Copy link
Member

FYI @agalakhov

@taiki-e taiki-e deleted the pin-project branch June 8, 2020 00:14
gregates pushed a commit to gregates/tokio-tungstenite that referenced this pull request Feb 24, 2024
websocket: add `can_read()` and `can_write()`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants