Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Prevent binary log files to crash snakemake execution with show-failed-logs #2827

Merged
merged 2 commits into from Apr 28, 2024
Merged

fix: Prevent binary log files to crash snakemake execution with show-failed-logs #2827

merged 2 commits into from Apr 28, 2024

Commits on Apr 22, 2024

  1. Add test for binary log file issue 

    This replicates snakemake#2826

Unfortunately this test seems to currently crush the pytest test
execution when failing. Given that it should not fail any more
I think this may be acceptable.
    Vito Zanotelli committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    0a29bbc View commit details
    Browse the repository at this point in the history

  2. Prevents printing attempt for binary logs 

    Previously a binary log file would cause `show_logs` to crash the whole
snakemake workflow execution with a `UnicodeDecodeError`.

Closes snakemake#2826
    Vito Zanotelli committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    7bddc8e View commit details
    Browse the repository at this point in the history