Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: list storage candidates #30

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

jeffhsu3
Copy link

Sorry accidentally closed the previous pull request. Did the suggested formatting changes. Still trying to figure out testing.

@vsoch vsoch changed the title List candidates feat: list storage candidates Mar 18, 2024
Copy link
Contributor

@johanneskoester johanneskoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Just some adaptations to the breaking change in the latest release.

snakemake_storage_plugin_gcs/__init__.py Outdated Show resolved Hide resolved
snakemake_storage_plugin_gcs/__init__.py Outdated Show resolved Hide resolved
snakemake_storage_plugin_gcs/__init__.py Outdated Show resolved Hide resolved
tests/tests.py Outdated Show resolved Hide resolved
tests/tests.py Outdated Show resolved Hide resolved
@johanneskoester
Copy link
Contributor

Mhm, now it fails. Is that my fault? If so, sorry if I broke something.

@jeffhsu3
Copy link
Author

jeffhsu3 commented May 4, 2024

Mhm, now it fails. Is that my fault? If so, sorry if I broke something.

Ah sorry I had used a character count for gcs:// and bucket name to obtain the list_blobs prefix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants