fix: allowing for accounts containing whitespace #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgvieira
reviewed
May 14, 2024
better wording Co-authored-by: Filipe G. Vieira <1151762+fgvieira@users.noreply.github.com>
|
Thanks for stepping in and the excellent review! |
fgvieira
reviewed
May 14, 2024
|
PS @fgvieira care to take a look again? |
fgvieira
approved these changes
May 14, 2024
cmeesters
pushed a commit
that referenced
this pull request
May 14, 2024
🤖 I have created a release *beep* *boop* --- ## [0.5.1](v0.5.0...v0.5.1) (2024-05-14) ### Bug Fixes * allowing for accounts containing whitespace ([#86](#86)) ([6993f2d](6993f2d)) * proper line ending status message ([#87](#87)) ([7b94aec](7b94aec)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported, the plugin will not deal with account names containing whitespace. (accounts containing whitespace were not anticipated).
This PR is an attempt to fix this.