Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproducing the error:
By calling the
sendSms
method of this library like this:There is a change to have this exception:
When the header string contains a space in the end (notice the space in the end after HTTP/2 200).
Fixing the error:
This issue comes from
HttpClient::execute
that does not properly trim the header. What it is doing is only removing empty lines (witharray_filter(explode("\n", $headerString), 'trim');
). Now it will keep removing the empty lines but also it will trim the lines so that this exception is not thrown.Where the error comes from:
Why do we have this error now but not before?
Because guzzle/psr7 updated a regex that was checking valid headers: https://github.com/guzzle/psr7/blob/master/src/MessageTrait.php
This has been released in 2.1.2 guzzle/psr7#492