Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tcp): only reset remote_last_ts if some data is enqueued #917

Merged
merged 1 commit into from
Apr 8, 2024
Merged

fix(tcp): only reset remote_last_ts if some data is enqueued #917

merged 1 commit into from
Apr 8, 2024

Conversation

copy
Copy link
Contributor

@copy copy commented Apr 8, 2024

I call send with a callback that often returns 0 (e.g. a real tcp socket that returns WouldBlock). This causes remote_last_ts being set to None and process being called even though nothing on the socket has changed.

Dirbaio
Dirbaio approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@Dirbaio Dirbaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@Dirbaio Dirbaio added this pull request to the merge queue Apr 8, 2024
Merged via the queue into smoltcp-rs:main with commit 114939a Apr 8, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dirbaio Dirbaio Dirbaio approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@copy @Dirbaio