-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement join/leave_multicast_group()
for IPv6
#914
Merged
Merged
Commits on Apr 2, 2024
-
Update PR smoltcp-rs#602: implement
join_multicast_group()
for IPv6This patch rebases @jgallagher's to the tip of the main branch, adding support for IPv6 multicast groups. As in the original PR, it is only possible to join groups by sending an initial MLDv2 Report packet. It is not yet possible to resend the change report, leave groups, respond to queries, etc.
Configuration menu - View commit details
-
Copy full SHA for 6c06cd9 - Browse repository at this point
Copy the full SHA 6c06cd9View commit details
Commits on Apr 17, 2024
-
IPv6: implement
leave_multicast_group()
Also, modify `test_join_ipv6_multicast_group()` so that it joins the mDNS multicast group instead of 0xfe80::1. Because the lower 24 bits of 0xfe80::01 match the lower part of the IPv6 address assigned to the test device by `crate::tests::setup()`, `has_multicast_group()` would always returns `true`.
Configuration menu - View commit details
-
Copy full SHA for cf1744a - Browse repository at this point
Copy the full SHA cf1744aView commit details -
Configuration menu - View commit details
-
Copy full SHA for d52a196 - Browse repository at this point
Copy the full SHA d52a196View commit details
Commits on Apr 19, 2024
-
Remove
Ipv6NotSupported
fromenum MulticastError
No part of the code uses this anymore.
Configuration menu - View commit details
-
Copy full SHA for 307952c - Browse repository at this point
Copy the full SHA 307952cView commit details
Commits on May 2, 2024
-
Address code review suggestions
- Handle payload copy outside of mld::AddressRecordRepr::emit() - On unit test, use the parsed Hop-by-Hop option instead of checking that the wire representation of the two structures is the same - Minor code changes
Configuration menu - View commit details
-
Copy full SHA for db25ee4 - Browse repository at this point
Copy the full SHA db25ee4View commit details
Commits on May 10, 2024
-
- Split mldv2_router_alert() in two, adding a new function named push_padn_option(u8) to emit a PadN hop-by-hop option after any other options have been pushed already - When emiting ReportRecordReprs, remove the conditional block that attempted to copy payload data over the destination record
Configuration menu - View commit details
-
Copy full SHA for 4d25db8 - Browse repository at this point
Copy the full SHA 4d25db8View commit details -
Configuration menu - View commit details
-
Copy full SHA for d0fd2c8 - Browse repository at this point
Copy the full SHA d0fd2c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 20aa66b - Browse repository at this point
Copy the full SHA 20aa66bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.