Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement join/leave_multicast_group() for IPv6 #914

Merged
merged 8 commits into from
May 14, 2024

Commits on Apr 2, 2024

  1. Update PR smoltcp-rs#602: implement join_multicast_group() for IPv6

    This patch rebases @jgallagher's to the tip of the main branch,
    adding support for IPv6 multicast groups. As in the original PR,
    it is only possible to join groups by sending an initial MLDv2
    Report packet. It is not yet possible to resend the change report,
    leave groups, respond to queries, etc.
    lucasvr committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    6c06cd9 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. IPv6: implement leave_multicast_group()

    Also, modify `test_join_ipv6_multicast_group()` so that it joins
    the mDNS multicast group instead of 0xfe80::1. Because the lower 24
    bits of 0xfe80::01 match the lower part of the IPv6 address assigned
    to the test device by `crate::tests::setup()`, `has_multicast_group()`
    would always returns `true`.
    lucasvr committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    cf1744a View commit details
    Browse the repository at this point in the history
  2. Apply rustfmt on igmp.rs

    lucasvr committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    d52a196 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. Remove Ipv6NotSupported from enum MulticastError

    No part of the code uses this anymore.
    lucasvr committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    307952c View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Address code review suggestions

    - Handle payload copy outside of mld::AddressRecordRepr::emit()
    - On unit test, use the parsed Hop-by-Hop option instead of checking
      that the wire representation of the two structures is the same
    - Minor code changes
    lucasvr committed May 2, 2024
    Configuration menu
    Copy the full SHA
    db25ee4 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Address code review

    - Split mldv2_router_alert() in two, adding a new function named
      push_padn_option(u8) to emit a PadN hop-by-hop option after any
      other options have been pushed already
    - When emiting ReportRecordReprs, remove the conditional block
      that attempted to copy payload data over the destination record
    lucasvr committed May 10, 2024
    Configuration menu
    Copy the full SHA
    4d25db8 View commit details
    Browse the repository at this point in the history
  2. Update unit test

    lucasvr committed May 10, 2024
    Configuration menu
    Copy the full SHA
    d0fd2c8 View commit details
    Browse the repository at this point in the history
  3. rustfmt

    lucasvr committed May 10, 2024
    Configuration menu
    Copy the full SHA
    20aa66b View commit details
    Browse the repository at this point in the history