Add BPF support for FreeBSD #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FreeBSD [source code](https://github.com/freebsd/freebsd-src/blob/b8afdda360e5915be3c2cf0d1438f511779b03db/sbin/ipf/ipf/bpf-ipf.h#L159) defines `SIZEOF_BPF_HDR` as 18 bytes, however during testing on a FreeBSD 14 system it was found that the size is actually 24 bytes, so that is what is used here in `smoltcp` when targeting FreeBSD.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #906 +/- ##
=======================================
Coverage 79.92% 79.92%
=======================================
Files 80 80
Lines 28234 28234
=======================================
Hits 22566 22566
Misses 5668 5668 ☔ View full report in Codecov by Sentry. |
|
Rapid! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for FreeBSD to
bpf.rs. This was tested on a FreeBSD system with an EtherCrab example which involves some reasonably complex networking.The FreeBSD source code defines
SIZEOF_BPF_HDRas 18 bytes, however during testing on a FreeBSD 14 system it was found that the size is actually 24 bytes, so that is what is used here insmoltcpwhen targeting FreeBSD. I'm open to corrections as I don't like just going of empirical evidence, but 18 bytes definitely did not work for the code I was testing with.The other constants were checked against the FreeBSD source code and are correct, so those were just a matter of adding the
target_oscfgparameters.