fix: accept any ip for IPv6 #900
Merged
+86
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #900 +/- ##
==========================================
+ Coverage 79.92% 79.94% +0.02%
==========================================
Files 80 80
Lines 28234 28238 +4
==========================================
+ Hits 22566 22576 +10
+ Misses 5668 5662 -6 ☔ View full report in Codecov by Sentry. |
|
@thvdveld: Thank you so much! 🍰 I was just looking into this issue when upgrading smoltcp in https://github.com/mitmproxy/mitmproxy_rs, what a fantastic timing. 🤩 Thank you for your work! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #899 .
However, I'm not sure if this is the intended behaviour of Any IP. Should we check if the packet is routed locally, or should we just accept any packet?