Remove generic in parse and emit functions #879
+181
−266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #879 +/- ##
==========================================
- Coverage 79.70% 79.68% -0.03%
==========================================
Files 78 78
Lines 28042 28002 -40
==========================================
- Hits 22351 22312 -39
+ Misses 5691 5690 -1 ☔ View full report in Codecov by Sentry. |
thvdveld
force-pushed
the
remove-generic-in-parse
branch
3 times, most recently
from
79768ed
to
7d99d71
Compare
thvdveld
force-pushed
the
remove-generic-in-parse
branch
2 times, most recently
from
2739262
to
a0ee819
Compare
thvdveld
force-pushed
the
remove-generic-in-parse
branch
from
a0ee819
to
36c89d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using
cargo bloatand I saw duplicate functions in wire. After this PR, the duplicates were gone. Removing the generics in the parse and emit functions prevents monomorphization of these functions. Preventing monomorphization reduces the binary size of the library.cargo bloat --release --example server --filter smoltcp:On main: 216.3KiB
On this branch: 202.5KiB
cargo bloat --release --example sixlowpan --filter smoltcp:On main: 213.9KiB
On this branch: 199.0KiB
I know that this is for an example of
std. However, the impact of code size will be smaller for embedded I suppose. The negative impact on user experience seems low since I didn't had to change much in the examples (only the ping example) and in the tests.