Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored the
IpPacket
struct, such that we can add more extensions headers to it for IPv6Previously it was not possible to create packets that had hop-by-hop options (for emitting). Reading hop-by-hop options was no problem though. However, I need to be able to emit hop-by-hop for RPL, which with these changes would be easier to add.
The only downside of this, is that we need
alloc
, or we could change it such thatIpv6HopByHop
has a heaplessVec
instead. This would then increase the size of theIpPacket
struct.I think this approach is better than #752, since now the structure of the IP packets is better represented than in #752.