GAT-based Device trait. #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dirbaio
force-pushed
the
gat-device
branch
2 times, most recently
from
cf45e77
to
44a532d
Compare
Dirbaio
force-pushed
the
gat-device
branch
3 times, most recently
from
828a703
to
ecccf5b
Compare
|
@Dirbaio looks like GAT is gonna be in 1.65 (rust-lang/rust#96709) - hopefully this gets merged then ! |
The current `'a` lifetime in the `Device` trait is essentially a workaround for lack of GATs. I'm just experimenting how this would look like, it'll have to wait until GATs are stable to go in. The main benefit is structs implementing `Device` can now borrow stuff. This wasn't possible before because the `for<'d> T: Device<'d>` bounds would essentially imply `T: 'static`.
|
bors r+ |
|
@Dirbaio awesome to see this merged, thanks! I hope you will also cut out a new smoltcp release in crates.io that has this changeset |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
'alifetime in theDevicetrait is essentially a workaround for lack of GATs.I'm just experimenting how this would look like, it'll have to wait until GATs are stable to go in.
The main benefit is structs implementing
Devicecan now borrow stuff. This wasn't possiblebefore because the
for<'d> T: Device<'d>bounds would essentially implyT: 'static.