Port to event-listener v5.0.0 #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MIRI deadlock looks like a false positive to me, but let me investigate it first. |
cc smol-rs/event-listener#105 Signed-off-by: John Nunley <dev@notgull.net>
Signed-off-by: John Nunley <dev@notgull.net>
Signed-off-by: John Nunley <dev@notgull.net>
Jules-Bertholet
force-pushed
the
notgull/new-evl
branch
from
26135fb
to
d28bdb0
Compare
- Miri was catching what I now know to be a legitimate leak, so I've fixed that. - The deadlock doesn't appear to be legitimate; replacing the futures with their blocking equivalents passes. I've marked these tests as skipped on MIRI for now. Signed-off-by: John Nunley <dev@notgull.net>
|
I've noticed that the choice of |
Signed-off-by: John Nunley <dev@notgull.net>
zeenix
requested changes
Feb 7, 2024
Signed-off-by: John Nunley <dev@notgull.net>
Signed-off-by: John Nunley <dev@notgull.net>
Signed-off-by: John Nunley <dev@notgull.net>
This was referenced Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc smol-rs/event-listener#105