Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not copy data before dropping #28

Merged
merged 1 commit into from Oct 25, 2022
Merged

Do not copy data before dropping #28

merged 1 commit into from Oct 25, 2022

Conversation

taiki-e
Copy link
Collaborator

@taiki-e taiki-e commented Oct 25, 2022

No description provided.

@taiki-e taiki-e requested a review from notgull October 25, 2022 12:35
notgull
notgull approved these changes Oct 25, 2022
View reviewed changes
Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@taiki-e taiki-e merged commit 465e0e2 into master Oct 25, 2022
@taiki-e taiki-e deleted the taiki-e/drop branch October 25, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notgull notgull notgull approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@taiki-e @notgull